Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NAS-132315 / 24.10.1 / fix minor cosmetic ixnvdimm output (by yocalebo) #241

Merged
merged 1 commit into from
Nov 6, 2024
Merged

NAS-132315 / 24.10.1 / fix minor cosmetic ixnvdimm output (by yocalebo) #241

merged 1 commit into from
Nov 6, 2024

Conversation

bugclerk
Copy link

@bugclerk bugclerk commented Nov 6, 2024

Noticed while working on an unrelated PR. Noticed ixnvdimm output looked like this

==================== /dev/nmem0 ====================Module:
vendor: ce01 device: 4e39 revision: 34
subvendor: c180 subdevice: 4331 subrevision: 01
serial: 10680000

With the fix in place, it looks like this

==================== /dev/nmem0 ====================
Module:
vendor: ce01 device: 4e39 revision: 34
subvendor: c180 subdevice: 4331 subrevision: 01
serial: 10680000

Original PR: https://github.com/truenas/ixdiagnose/pull/240
Jira URL: https://ixsystems.atlassian.net/browse/NAS-132315

@yocalebo @bugclerk
fix minor cosmetic ixnvdimm output
591d4e7 
(cherry picked from commit 4c75d4a)
@yocalebo yocalebo merged commit b694126 into stable/electriceel Nov 6, 2024
5 checks passed
@yocalebo yocalebo deleted the NAS-132315-24.10.1 branch November 6, 2024 19:24
@bugclerk
Copy link
Author

bugclerk commented Nov 6, 2024

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Nov 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yocalebo yocalebo yocalebo approved these changes

Assignees

@yocalebo yocalebo

Labels
no-time-tracked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bugclerk @yocalebo